HBASE-29586 Setting hbase.oldwals.cleaner.thread.size to negative value will throw IllegalArgumentExce… #7293

wangxiangdong123 · 2025-09-11T02:51:57Z

…tion

Copilot

Pull Request Overview

This PR addresses HBASE-29586 by adding validation to prevent IllegalArgumentException when the hbase.oldwals.cleaner.thread.size configuration is set to a negative or zero value.

Adds input validation to check for non-positive thread pool size values
Logs a warning and uses default value when invalid configuration is detected
Prevents runtime exceptions by early return when invalid values are encountered

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

wangxiangdong123 · 2025-10-07T12:06:48Z

谢谢,邮件已收到，祝生活愉快，工作顺利！

Apache9 · 2025-10-07T12:08:36Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/LogCleaner.java

+      LOG.warn(
+        "The configuration {} has been set to an invalid value {}, "
+          + "the default value {} will be used, no need to update.",
+        OLD_WALS_CLEANER_THREAD_SIZE, newSize, DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);


Oh, wait a minute, here we just return, which means we will keep the old value, not use the default value?

Apache-HBase · 2025-10-11T07:07:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 49s		master passed
+1 💚	compile	3m 29s		master passed
+1 💚	checkstyle	0m 38s		master passed
+1 💚	spotbugs	1m 42s		master passed
+1 💚	spotless	0m 49s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	3m 26s		the patch passed
+1 💚	javac	3m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 37s		the patch passed
+1 💚	spotbugs	1m 43s		the patch passed
+1 💚	hadoopcheck	12m 19s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		40m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7293
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 4e4e4ec234d9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `acf11d4`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-11T10:31:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 36s		master passed
+1 💚	compile	0m 57s		master passed
+1 💚	javadoc	0m 29s		master passed
+1 💚	shadedjars	6m 16s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	compile	0m 57s		the patch passed
+1 💚	javac	0m 57s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed
+1 💚	shadedjars	6m 13s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	217m 51s		hbase-server in the patch passed.
		245m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7293
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 525adabca594 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `acf11d4`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/3/testReport/
Max. process+thread count	4125 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wangxiangdong123 · 2025-12-12T14:46:51Z

谢谢,邮件已收到，祝生活愉快，工作顺利！

guluo2016 · 2025-12-12T14:47:56Z

Thanks for the fix!
LGTM

NihalJain · 2025-12-15T05:24:39Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/LogCleaner.java

  public void onConfigurationChange(Configuration conf) {
    int newSize = conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE, DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);
+    if (newSize <= 0) {
+      LOG.warn(


nit: maybe just put as debug. also maybe sync with impl at

hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java

Line 180 in 8b17149

if (newThreadCount < 1) {

Apache-HBase · 2025-12-15T11:25:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 21s		master passed
+1 💚	compile	3m 5s		master passed
+1 💚	checkstyle	0m 54s		master passed
+1 💚	spotbugs	1m 40s		master passed
+1 💚	spotless	0m 49s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 42s		the patch passed
+1 💚	compile	2m 59s		the patch passed
+1 💚	javac	2m 59s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 51s		the patch passed
+1 💚	spotbugs	1m 29s		the patch passed
+1 💚	hadoopcheck	9m 46s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 40s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		34m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7293
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 9d42501b92a7 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c36cb16`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-15T14:48:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 10s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 19s		master passed
+1 💚	compile	0m 59s		master passed
+1 💚	javadoc	0m 28s		master passed
+1 💚	shadedjars	5m 21s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 19s		the patch passed
+1 💚	compile	1m 8s		the patch passed
+1 💚	javac	1m 8s		the patch passed
+1 💚	javadoc	0m 33s		the patch passed
+1 💚	shadedjars	5m 36s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	212m 4s		hbase-server in the patch passed.
		237m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7293
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 090b90dffe3d 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c36cb16`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/4/testReport/
Max. process+thread count	4056 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7293/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…ue will throw IllegalArgumentException (#7293) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peng Lu <[email protected]>

…ue will throw IllegalArgumentException (apache#7293) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peng Lu <[email protected]>

HBASE-29586 Setting to negative value will throw IllegalArgumentExcep…

d738311

…tion

This comment has been minimized.

Sign in to view

HBASE-29586 Setting hbase.oldwals.cleaner.thread.size check

4673dba

This comment has been minimized.

Sign in to view

Apache9 requested a review from Copilot October 7, 2025 10:26

Copilot AI reviewed Oct 7, 2025

View reviewed changes

Apache9 approved these changes Oct 7, 2025

View reviewed changes

Apache9 requested changes Oct 7, 2025

View reviewed changes

fix HBASE-29586 the previous wal cleanerr

acf11d4

wangxiangdong123 requested a review from Apache9 October 11, 2025 07:42

guluo2016 approved these changes Dec 12, 2025

View reviewed changes

NihalJain reviewed Dec 15, 2025

View reviewed changes

NihalJain approved these changes Dec 15, 2025

View reviewed changes

HBASE-29586 Fix the info to debug

c36cb16

guluo2016 merged commit 7f1f81a into apache:master Dec 18, 2025
1 check passed

HBASE-29586 Setting hbase.oldwals.cleaner.thread.size to negative value will throw IllegalArgumentExce… #7293

HBASE-29586 Setting hbase.oldwals.cleaner.thread.size to negative value will throw IllegalArgumentExce… #7293

Uh oh!

Conversation

wangxiangdong123 commented Sep 11, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

wangxiangdong123 commented Oct 7, 2025 via email

Uh oh!

Apache9 Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Oct 11, 2025

Uh oh!

Apache-HBase commented Oct 11, 2025

Uh oh!

wangxiangdong123 commented Dec 12, 2025 via email

Uh oh!

guluo2016 commented Dec 12, 2025

Uh oh!

NihalJain Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Dec 15, 2025

Uh oh!

Apache-HBase commented Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NihalJain Dec 15, 2025 •

edited

Loading